<html>
<head><meta charset="utf-8"><title>rebasing · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html">rebasing</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="222387530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> devsnek <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387530">(Jan 12 2021 at 03:20)</a>:</h4>
<p>so it seems that bors doesn't respect <code>squash!</code> commits, and there is no standard process by which a reviewer warns you before they r+, and the contributing guidelines ask you not to force push, so what are you supposed to do exactly</p>



<a name="222387582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387582">(Jan 12 2021 at 03:21)</a>:</h4>
<blockquote>
<p>the contributing guidelines ask you not to force push</p>
</blockquote>
<p>they do? force pushing is pretty normal IME</p>



<a name="222387587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387587">(Jan 12 2021 at 03:21)</a>:</h4>
<p>What is a <code>squash!</code> commit?</p>



<a name="222387599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387599">(Jan 12 2021 at 03:21)</a>:</h4>
<p>Yeah, I force push all the time.</p>



<a name="222387619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387619">(Jan 12 2021 at 03:21)</a>:</h4>
<p>If they say that we should update them.</p>



<a name="222387670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387670">(Jan 12 2021 at 03:22)</a>:</h4>
<p>FYI, we now have <code>@bors squash</code> so you can ask someone to do that.</p>



<a name="222387685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387685">(Jan 12 2021 at 03:22)</a>:</h4>
<p>Also, how do you rebase without force-pushing?</p>



<a name="222387707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> devsnek <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387707">(Jan 12 2021 at 03:23)</a>:</h4>
<blockquote>
<p>they do? force pushing is pretty normal IME</p>
</blockquote>
<p>for example -&gt; <a href="https://github.com/rust-lang/rust/pull/78684#issuecomment-720736750">https://github.com/rust-lang/rust/pull/78684#issuecomment-720736750</a></p>
<blockquote>
<p>What is a squash! commit?</p>
</blockquote>
<p>when you rebase, git can automatically squash commits which have subjects starting with <code>squash!</code> and <code>fixup!</code></p>



<a name="222387743"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387743" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387743">(Jan 12 2021 at 03:24)</a>:</h4>
<p>That doesn't say "don't force push", it says "add new commits when you make new changes":</p>
<blockquote>
<p>If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.</p>
</blockquote>
<p>Perhaps we should clarify that.</p>



<a name="222387818"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387818" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> devsnek <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387818">(Jan 12 2021 at 03:25)</a>:</h4>
<p>might be good to update it yeah. i'm just sad that now and forever i will have a commit in rust named <code>squash! fix wasi</code> <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="222387926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222387926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222387926">(Jan 12 2021 at 03:27)</a>:</h4>
<p>By the way, the way I squash is with <code>git rebase -i (git merge-base master HEAD)</code>.</p>



<a name="222388009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222388009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> devsnek <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222388009">(Jan 12 2021 at 03:28)</a>:</h4>
<p>yeah generally i would just amend locally and then force push, since gh ui does support showing you what changed in a force push</p>



<a name="222388049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222388049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222388049">(Jan 12 2021 at 03:29)</a>:</h4>
<p>It's really hard to give general advice, it depends on the PR whether amending commits or pushing updates as new commits makes sense.</p>



<a name="222388412"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222388412" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222388412">(Jan 12 2021 at 03:36)</a>:</h4>
<p><span class="user-mention silent" data-user-id="219805">devsnek</span> <a href="#narrow/stream/122651-general/topic/rebasing/near/222388009">said</a>:</p>
<blockquote>
<p>yeah generally i would just amend locally and then force push, since gh ui does support showing you what changed in a force push</p>
</blockquote>
<p>It does? News to me <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="222388437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222388437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222388437">(Jan 12 2021 at 03:37)</a>:</h4>
<p>I agree with what <span class="user-mention silent" data-user-id="116122">simulacrum</span> said: it really is dependent on the situation. We should probably say something like that in highfive's message so it doesn't feel like a global rule.</p>



<a name="222414620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222414620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222414620">(Jan 12 2021 at 10:45)</a>:</h4>
<p>Github's force push diffs fail to work pretty often to me.</p>



<a name="222414951"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222414951" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222414951">(Jan 12 2021 at 10:48)</a>:</h4>
<p>I have never seen them working I think.</p>



<a name="222460692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222460692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222460692">(Jan 12 2021 at 16:55)</a>:</h4>
<p>That's likely because you <em>also</em> rebase at the same time.</p>



<a name="222460757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222460757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222460757">(Jan 12 2021 at 16:55)</a>:</h4>
<p>I have:</p>
<div class="codehilite"><pre><span></span><code>[alias]
        safe-rebase = !git rebase $(git merge-base HEAD @{upstream})
</code></pre></div>



<a name="222461183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222461183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222461183">(Jan 12 2021 at 16:58)</a>:</h4>
<p>When I'm trying to be very easy for a reviewer to follow along, I'll do a rebase of just my commits, force-push that (generating a useful diff) and then rebase on master (to catch conflicts / etc) and force-push that again</p>



<a name="222491213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222491213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222491213">(Jan 12 2021 at 20:41)</a>:</h4>
<p>Usually when I squash I'm rebasing on the merge-base, so I don't think that's the issue. But I didn't even know of a GitHub force-push diff feature, so <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="222491260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222491260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222491260">(Jan 12 2021 at 20:41)</a>:</h4>
<p>By the way, you can use <code>@{u}</code> instead of <code>@{upstream}</code> – not sure if you know already, but thought it's worth mentioning :)</p>



<a name="222491309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222491309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222491309">(Jan 12 2021 at 20:41)</a>:</h4>
<p>I often use <code>git diff @{u}...</code> after squashing to make sure I didn't make any changes aside from moving commits around.</p>



<a name="222496160"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222496160" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222496160">(Jan 12 2021 at 21:20)</a>:</h4>
<p>it's not worth putting shorthands like that in scripts / aliases. I don't have to type them there.</p>



<a name="222496362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222496362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222496362">(Jan 12 2021 at 21:22)</a>:</h4>
<p>and I don't find myself typing that at the command line often (because I have the alias, I suppose)</p>



<a name="222510889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222510889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222510889">(Jan 12 2021 at 23:27)</a>:</h4>
<p>Yeah, I just wanted to make sure you knew in case you do type it often :)</p>
<p>As I said, I type <code>git diff @{u}..</code> fairly often so it's useful for me.</p>



<a name="222994323"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994323" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994323">(Jan 16 2021 at 17:32)</a>:</h4>
<p>AFAIK we have a general "no squash or rebase during review" policy? At least that's what I was told, and it's what I have been telling people. Squashing or rebasing during review makes it much harder to know what changed since the last review.<br>
However, is this documented somewhere, so that I can link contributors to some document instead of having to explain it each time?</p>



<a name="222994351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994351">(Jan 16 2021 at 17:33)</a>:</h4>
<p>it should be noted on their first pr by highfive</p>



<a name="222994356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994356">(Jan 16 2021 at 17:33)</a>:</h4>
<p>but it's also not always the right policy</p>



<a name="222994363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994363">(Jan 16 2021 at 17:33)</a>:</h4>
<p>yeah I remember that. but I assume people forget, and that's not something to link to.</p>



<a name="222994375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994375">(Jan 16 2021 at 17:33)</a>:</h4>
<p>e.g. if the PR changes &lt;100 lines I personally prefer they keep it clean commit history wise</p>



<a name="222994415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994415">(Jan 16 2021 at 17:34)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/122651-general/topic/rebasing/near/222994356">said</a>:</p>
<blockquote>
<p>but it's also not always the right policy</p>
</blockquote>
<p>sure, but it's the right default IMO. it's better than people squashing and rebasing without being prompted to do so ;)</p>



<a name="222994421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994421">(Jan 16 2021 at 17:34)</a>:</h4>
<p>yes, that seems right</p>



<a name="222994435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994435">(Jan 16 2021 at 17:34)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/122651-general/topic/rebasing/near/222994375">said</a>:</p>
<blockquote>
<p>e.g. if the PR changes &lt;100 lines I personally prefer they keep it clean commit history wise</p>
</blockquote>
<p>In that case I'll ask them to squash once I am happy, right before <code>r+</code>. but when there are still changes, I have to re-read it all, and even 100 line diffs can contain some not entirely trivial bits.</p>



<a name="222994470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994470">(Jan 16 2021 at 17:35)</a>:</h4>
<p>yeah I guess it depends, I usually go long enough between reviews to lose just enough context to not really be able to apply diffs and check if they resolve things</p>
<p>we have</p>
<blockquote>
<p>Rust follows a no merge-commit policy, meaning, when you encounter merge conflicts you are expected to always rebase instead of merging. E.g. always use rebase when bringing the latest changes from the master branch to your feature branch. Also, please make sure that fixup commits are squashed into other related commits with meaningful commit messages.</p>
</blockquote>



<a name="222994473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994473">(Jan 16 2021 at 17:35)</a>:</h4>
<p>in dev guide</p>



<a name="222994492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994492">(Jan 16 2021 at 17:36)</a>:</h4>
<p>but that's rather the opposite, under opening a new pr, when it is the right advice</p>



<a name="222994577"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994577" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994577">(Jan 16 2021 at 17:37)</a>:</h4>
<p>we should definitely write something up</p>



<a name="222994609"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994609" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994609">(Jan 16 2021 at 17:37)</a>:</h4>
<p>could always link to <a href="https://github.com/rust-lang/highfive/blob/master/highfive/newpr.py#L25">https://github.com/rust-lang/highfive/blob/master/highfive/newpr.py#L25</a> which is rather awkward in the meantime :)</p>



<a name="222994678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/rebasing/near/222994678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/rebasing.html#222994678">(Jan 16 2021 at 17:38)</a>:</h4>
<p>the horizontal scrollbar doesn't help^^</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>